New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream0 dt output for merge #1450
Merged
martinthomson
merged 35 commits into
quicwg:master
from
ekr:stream0_dt_output_for_merge
Jun 25, 2018
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
42f55df
Output of Stream 0 Design Team.
ekr cab8295
Fix changelog
ekr 984ecc8
Fix whitespace
ekr 36899e5
Offset and length fields in CRYPTO_HS are not optional
ekr f8f172f
Remove EMPTY_ACK
ianswett 70b26e8
Incorporate the comments from PR#1377
ekr af70f23
Remove EMPTY_ACK
ianswett aa1b683
Update draft-ietf-quic-transport.md
ianswett 927cf12
Add the TLS diagrams
ekr 74300a1
Redact diagram from the TLS doc
ekr 04fd321
Ian Swett's comments
ekr bf9c62c
server-initiated streams start from 1
ekr 77155f9
Remove last TODO
ekr 779b3a0
Minor editorial
ekr d3b055a
Remove the advice on how to use coalesced packets for recovery.
ekr 48c9b9f
Self-review, ready to submit
ekr 396c318
Some more cleanup
ekr 777114a
Fix compile errors
ekr a4ad49b
Restore Generating Acknowledgements
ianswett 6b36300
Mike's comments
ianswett 0cfdf67
Merge pull request #34 from ekr/ianswett-mike-comments
ekr 4065266
Fix retry and remove optimizations
ianswett 954c585
Merge pull request #35 from ekr/ianswett-mike2
ekr d814642
Martin's comments
ianswett da0d8ec
Ensures that
ianswett 89c45a6
Merge pull request #36 from ekr/ianswett-martin
ekr daea861
Address MT's comments on TLS
ekr 3aea50d
MT/Bishop comments on transport
ekr bd5f9ff
Ian's comments
ekr e2ed4db
Merge pull request #37 from ekr/martins_comments
ekr 7a780db
Fix build breaks
MikeBishop 4db5568
Extra word
MikeBishop 8d57711
remove "the the"
martinthomson a2aabfe
More errors around delivering to TLS out of order
martinthomson 2473966
The online editor is terrible
martinthomson File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that this works. Consider EndOfEarlyData, which could be lost, then later repaired. The end of the previously installed encryption level (aside from being only loosely defined) for CRYPTO is 0, so EOED would extend past that. Also, if you take a looser interpretation, then a delayed 0-RTT STREAM frame might also extend that stream beyond the point where the server cut over to reading Handshake or 1-RTT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right to me. First, the 0-RTT STREAM frame isn't relevant, because this is just about CRYPTO_HS.
As for EOED, here's what happens ordinarily (no loss)
If instead you get CH, CFIN, EOED, here's what happens: