Modify codepoints on decoder and request/push streams for consistency #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prefix lengths remain the same but the instruction bits now follow the rule that each instruction has at most one '1' bit. Fixes #1471
MikeBishop
approved these changes
Jun 22, 2018
| two-bit pattern. If the entry is in the dynamic table with an absolute index | ||
| greater than Base Index, the representation starts with the '0101' four-bit | ||
| greater than Base Index, the representation starts with the '0000' four-bit | ||
| pattern. |
There was a problem hiding this comment.
This change is fine, but didn't we separate out the Post-Base things to their own headers? Did we miss one?
There was a problem hiding this comment.
It has its own section but the normative text is in this section.
martinthomson
approved these changes
Jun 25, 2018
|
I'm not concerned about this change delaying interop dramatically. Implicit acks landed last week and was a bigger change. |
This is somewhat superficial, but we're changing it anyways so bear with me. HEADER_ACK and STREAM_CANCEL are almost identical, so code processing them should be next to each other. By swapping TSS and Stream Cancel codepoints, the processing code might be more readable.
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Jun 26, 2018
Summary: quicwg/base-drafts#1472 Reviewed By: mjoras Differential Revision: D8641256 fbshipit-source-id: b87f8d30d948e23548638675c1a8afb627e8f610
|
@martinthomson, that's perhaps technically true, but I don't think this pushes out interop noticeably. The bit sequences are the same length they previously were, and were always arbitrary bit sequences. This should be a trivial change to incorporate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prefix lengths remain the same but the instruction bits now follow the rule that each instruction has at most one '1' bit.
Fixes #1471