Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension frames #1473

Merged
merged 6 commits into from Jun 26, 2018
Merged

Extension frames #1473

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e4725ac
Extension frames
martinthomson Jun 25, 2018
81e10cc
PROTOCOL_VIOLATION for bad frame type
martinthomson Jun 26, 2018
89c0aef
WIP
martinthomson Jun 26, 2018
6fa28c2
reflow
martinthomson Jun 26, 2018
09b7e94
Simplify
martinthomson Jun 26, 2018
fdcc44c
Merge branch 'master' into extend-frames
martinthomson Jun 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Expand Up @@ -944,8 +944,8 @@ endpoint cannot send a frame of a type that is unknown to its peer.

An extension to QUIC that wishes to use a new type of frame MUST first ensure
that a peer is able to understand the frame. An endpoint can use a transport
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have an example here at some point, but since we don't have any extension frames, I guess that's for the future?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's always @larseggert's suggestion that BLOCKED et al. should be extensions. That's been on hold while we wait for an extension mechanism to be defined, but it's a perfectly reasonable one. Define a transport parameter inform_if_blocked and if that's set, the various BLOCKED frames are understood.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a reasonable suggestion to me.

parameter to signal its willingness to receive a new type of frame, or even
multiple types of frame with the one transport parameter.
parameter to signal its willingness to receive one or more extension frame types
with the one transport parameter.

An IANA registry is used to manage the assignment of frame types, see
{{iana-frames}}.
Expand Down