Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added change logs for -13 #1488

Merged
merged 4 commits into from Jun 27, 2018
Merged

Added change logs for -13 #1488

merged 4 commits into from Jun 27, 2018

Conversation

martinthomson
Copy link
Member

These are big, so I would appreciate a second pair of eyes. That gives @MikeBishop a chance to fixup #1359, which I would like to see in -13 (let's concentrate all the large changes on the one version).

Copy link
Collaborator

@ekr ekr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- The cryptographic handshake uses CRYPTO frames, not stream 0
- QUIC packet protection is used in place of TLS record protection
- Separate QUIC packet number spaces are used for the handshake
- Changed Retry to be independent of the cryptographic handshake
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would promote this

Copy link
Contributor

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find anything you missed in recovery or transport.

Copy link
Contributor

@MikeBishop MikeBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple things directly. Ship it!

@martinthomson martinthomson merged commit ee2d80d into master Jun 27, 2018
@martinthomson martinthomson deleted the changelog-13 branch October 26, 2018 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants