Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Retry packet #1498

Merged
merged 13 commits into from
Jul 31, 2018
Merged

Rework Retry packet #1498

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b375544
Rework Retry packet
martinthomson Jun 28, 2018
bf3f675
Review comments
martinthomson Jun 29, 2018
55e910f
Address various comments
martinthomson Jul 3, 2018
fdb837f
Collapse a few things
martinthomson Jul 3, 2018
dd13b0e
Add PN offset calculation adjustment for Initial packet
martinthomson Jul 3, 2018
c96058f
Grammar hard
martinthomson Jul 6, 2018
e375657
Redo ODCIL encoding. Closes #1535.
martinthomson Jul 8, 2018
555ae81
Tweak language
martinthomson Jul 8, 2018
19174cf
Grammar fixes, leftover invalid text
martinthomson Jul 9, 2018
21f9ba5
Refine token use and reuse constraints
martinthomson Jul 9, 2018
7d96aa9
FOUR bits
martinthomson Jul 11, 2018
dbc58a1
ODCIL will never be <8
martinthomson Jul 12, 2018
cd9cdb4
a new value
martinthomson Jul 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions draft-ietf-quic-tls.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,6 +745,9 @@ handled separately.
sample_offset = 6 + len(destination_connection_id) +
len(source_connection_id) +
len(payload_length) + 4
if packet_type == Initial:
sample_offset += len(token_length) +
len(token)
~~~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I am missing something, len(token_length) is only available after the PN has been decrypted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we have a circular dependency when decrypting. See issue #1535.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. This is actually addressed later, as the token has now moved in front of the PN.

To ensure that this process does not sample the packet number, packet number
Expand Down