Application close #1528
Merged
Application close #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of the Frame Type field meant that pointing APPLICATION_CLOSE at CONNECTION_CLOSE was a mistake. This isn't purely editorial, because it could be argued that the last version of the draft modified APPLICATION_CLOSE. We'll have to ensure taht this is included in the changelog. Closes #1508.
MikeBishop
approved these changes
Jul 6, 2018
janaiyengar
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition of the Frame Type field meant that pointing
APPLICATION_CLOSE at CONNECTION_CLOSE was a mistake.
This isn't purely editorial, because it could be argued that the last
version of the draft modified APPLICATION_CLOSE. We'll have to ensure
taht this is included in the changelog.
Closes #1508.