Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bit prefix verbiage to match figure #1537

Closed

Conversation

dtikhonov
Copy link
Member

No description provided.

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -qpack labels Jul 9, 2018
@MikeBishop
Copy link
Contributor

No, the existing text is correct and the change is incorrect. The H bit is part of the string prefix, so the string prefix is one bit longer than the string's length field. See the definition of prefixed strings in 5.1.2.

However, I hate how confusing that terminology is, so if you'd like to propose an improvement to that, please. ;-)

@dtikhonov
Copy link
Member Author

Sure confused me! I'll have to reread it.

@martinthomson
Copy link
Member

Right. Perhaps it would be better to say "a string literal with an N-bit-prefixed length" or something like that.

@dtikhonov
Copy link
Member Author

Having read the document again, I think it is fine as-is. The prefix is described in the String Literals section which comes before the operation definitions and the accompanying figures.

Closing.

@dtikhonov dtikhonov closed this Jul 10, 2018
@dtikhonov dtikhonov deleted the 201807072210-fix-bit-verbiage branch July 10, 2018 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-qpack editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants