-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PADDING counts towards bytes in flight #1540
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
96c1d03
PADDING counts towards byte in flight
ianswett 1e34037
Clarify byte_in_flight
ianswett aa00f6b
Update draft-ietf-quic-recovery.md
ianswett 4be49f9
Update draft-ietf-quic-recovery.md
ianswett bbfcde0
in-flight
ianswett 7a35971
Integrate Martin's suggestion
ianswett 02c636d
Long header CRYPTO packets
ianswett a72ec02
packets
ianswett c32e591
Jana's comments
ianswett be54deb
65 chars
janaiyengar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,7 +111,7 @@ important to the loss detection and congestion control machinery below. | |
frame. | ||
|
||
* PADDING frames do cause packets containing them to count towards bytes in | ||
flight, but do not instigate acknowledgement. | ||
flight, but do not elicit acknowledgement. | ||
|
||
* In flight packets are those that contain at least one retransmittable frame | ||
or at least one PADDING frame. All in flight packets count towards bytes | ||
|
@@ -589,7 +589,8 @@ sent_packets: | |
|
||
: An association of packet numbers to information about them, including a number | ||
field indicating the packet number, a time field indicating the time a packet | ||
was sent, a boolean indicating whether the packet is ack only, and a bytes | ||
was sent, a boolean indicating whether the packet is ack only, a boolen | ||
indicating whether it counts towards bytes in flight, and a bytes | ||
field indicating the packet's size. sent_packets is ordered by packet number, | ||
and packets remain in sent_packets until acknowledged or lost. A sent_packets | ||
data structure is maintained per packet number space, and ACK processing only | ||
|
@@ -630,9 +631,12 @@ are as follows: | |
|
||
* packet_number: The packet number of the sent packet. | ||
|
||
* is_ack_only: A boolean that indicates whether a packet only contains an | ||
ACK frame. If true, it is still expected an ack will be received for | ||
this packet, but it is not retransmittable or in flight. | ||
* ack_only: A boolean that indicates whether a packet only contains an | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. s/only contains an/contains only/ |
||
ACK, ACK_ECN or PADDING frame(s). If true, it is still expected an ack will | ||
be received for this packet, but it is not retransmittable. | ||
|
||
* in_flight: A boolean that indicates whether the packet counts towards | ||
bytes in flight. | ||
|
||
* is_handshake_packet: A boolean that indicates whether a packet contains | ||
handshake data. | ||
|
@@ -643,13 +647,13 @@ are as follows: | |
Pseudocode for OnPacketSent follows: | ||
|
||
~~~ | ||
OnPacketSent(packet_number, is_ack_only, is_handshake_packet, | ||
sent_bytes): | ||
OnPacketSent(packet_number, ack_only, in_flight, | ||
is_handshake_packet, sent_bytes): | ||
largest_sent_packet = packet_number | ||
sent_packets[packet_number].packet_number = packet_number | ||
sent_packets[packet_number].time = now | ||
sent_packets[packet_number].ack_only = is_ack_only | ||
if !is_ack_only: | ||
sent_packets[packet_number].ack_only = ack_only | ||
if !ack_only: | ||
if is_handshake_packet: | ||
time_of_last_sent_handshake_packet = now | ||
time_of_last_sent_retransmittable_packet = now | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
boolean