Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the discussion about when to use long header #1550

Merged

Conversation

kazuho
Copy link
Member

@kazuho kazuho commented Jul 11, 2018

I think current text is a bit too restrictive (without necessity), and that it might cause misunderstanding.

  • V2 and later versions should have the freedom to decide when to trigger version negotiation (note: version negotiation requires the use of long header packets).
  • Removes the false impression that the use of a path always start with a long header. That is not the case for v1 due to involuntary NAT rebinding.

* V2 and later versions should have the freedom to decide when to
  trigger version negotiation (note: version negotiation requires
  the use of long header packets).
* Removes the false impression that the use of a path always start
  with a long header. That is not the case for v1 due to
  involuntary NAT rebinding.
@martinthomson
Copy link
Member

While the text is correct in the sense that you can't do version negotiation without packets that use the long header, I see your point here. This is more consistent with the minimalist nature of the doc, which avoids implying basically anything about what use of any of these packets implies.

My natural inclination would have been to address this sort of concern with an example in the appendix along the lines of:

  • the first packets exchanged in a flow use the long header

Do you think that we should add that as well?

@kazuho
Copy link
Member Author

kazuho commented Jul 12, 2018

My natural inclination would have been to address this sort of concern with an example in the appendix along the lines of:

  • the first packets exchanged in a flow use the long header

Do you think that we should add that as well?

I think that it would be a good idea to add that as well, under the premise that it would be written as an anticipation rather than a requirement that all the future versions of QUIC will comply with.

@martinthomson martinthomson merged commit 8f64ad3 into quicwg:master Jul 12, 2018
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -invariants labels Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-invariants editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants