Replace alarm with timer #1559
Merged
Replace alarm with timer #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1383
janaiyengar
reviewed
Jul 14, 2018
draft-ietf-quic-recovery.md
Outdated
| @@ -111,8 +111,8 @@ of frames contained in a packet affect recovery and congestion control logic: | |||
| to as "retransmittable" below. | |||
|
|
|||
| * Long header packets that contain CRYPTO frames are critical to the | |||
| performance of the QUIC handshake and use shorter timers for acknowledgement | |||
| and retransmission. | |||
| performance of the QUIC handshake and use shorter timeouts for | |||
There was a problem hiding this comment.
undo this change -- shorter timeouts not timers.
draft-ietf-quic-recovery.md
Outdated
| When CRYPTO frames are sent, the sender SHOULD set a timer for the handshake | ||
| timeout period. Upon timeout, the sender MUST retransmit all unacknowledged | ||
| CRYPTO data by calling RetransmitAllUnackedHandshakeData(). On each | ||
| consecutive firing of the handshake timer without receiving an |
draft-ietf-quic-recovery.md
Outdated
| To reduce latency, it is RECOMMENDED that the sender set and allow the TLP alarm | ||
| to fire twice before setting an RTO alarm. In other words, when the TLP alarm | ||
| To reduce latency, it is RECOMMENDED that the sender set and allow the TLP timer | ||
| to fire twice before setting an RTO timer. In other words, when the TLP timer | ||
| fires the first time, a TLP packet is sent, and it is RECOMMENDED that the TLP |
There was a problem hiding this comment.
you should just do s/fires/expires/ through the doc
draft-ietf-quic-recovery.md
Outdated
| When the last TLP packet is sent, an alarm is scheduled for the RTO period. When | ||
| this alarm fires, the sender sends two packets, to evoke acknowledgements from | ||
| the receiver, and restarts the RTO alarm. | ||
| When the last TLP packet is sent, a timer is scheduled for the RTO period. When |
There was a problem hiding this comment.
s/a timer is scheduled/a timer is set/
draft-ietf-quic-recovery.md
Outdated
| if (smoothed_rtt == 0): | ||
| alarm_duration = 2 * kInitialRtt | ||
| timer_duration = 2 * kInitialRtt |
There was a problem hiding this comment.
s/timer_duration/timeout/
|
Thanks Jana, this PR got a bit larger, PTAL |
janaiyengar
approved these changes
Jul 15, 2018
|
I don't know why circle is still showing breakage with the old qpack draft. I'll merge this. |
|
@ianswett I think you missed the transport doc (migration section) |
|
Should be done now in PR #1590 |
|
You're right, thanks for the PR! |
martinthomson
added
the
editorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1383