Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove packets from flight when RTO is verified #1582

Merged
merged 4 commits into from
Jul 19, 2018
Merged

Remove packets from flight when RTO is verified #1582

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c20ae7
Remove packets from flight when RTO is verified
ianswett Jul 18, 2018
710c52e
Update draft-ietf-quic-recovery.md
ianswett Jul 18, 2018
02077dc
Update draft-ietf-quic-recovery.md
ianswett Jul 19, 2018
bf18809
Update draft-ietf-quic-recovery.md
ianswett Jul 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,8 +728,9 @@ Pseudocode for OnPacketAcked follows:
// If a packet sent prior to RTO was acked, then the RTO
// was spurious. Otherwise, inform congestion control.
if (rto_count > 0 &&
acked_packet.packet_number > largest_sent_before_rto)
OnRetransmissionTimeoutVerified()
acked_packet.packet_number > largest_sent_before_rto):
OnRetransmissionTimeoutVerified(
acket_packet.packet_number)
handshake_count = 0
tlp_count = 0
rto_count = 0
Expand Down Expand Up @@ -1024,7 +1025,6 @@ Variables required to implement the congestion control mechanisms
are described in this section.

ecn_ce_counter:

: The highest value reported for the ECN-CE counter by the peer in an ACK_ECN
frame. This variable is used to detect increases in the reported ECN-CE
counter.
Expand Down Expand Up @@ -1098,7 +1098,7 @@ acked_packet from sent_packets.

### On New Congestion Event

Invoked from ProcessECN and OnPacketLost when a new congestion event is
Invoked from ProcessECN and OnPacketsLost when a new congestion event is
detected. Starts a new recovery period and reduces the congestion window.

~~~
Expand Down Expand Up @@ -1147,11 +1147,17 @@ are detected lost.
### On Retransmission Timeout Verified

QUIC decreases the congestion window to the minimum value once the
retransmission timeout has been verified.
retransmission timeout has been verified and removes any packets
sent before the newly acknowledged RTO packet.

~~~
OnRetransmissionTimeoutVerified()
OnRetransmissionTimeoutVerified(packet_number)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think OnPacketAcked() needs to be changed as well too pass in largest_sent packet right?

congestion_window = kMinimumWindow
// Declare all packets prior to packet_number lost.
for (sent_packet: sent_packets):
if (sent_packet.packet_number < packet_number):
bytes_in_flight -= lost_packet.bytes
sent_packets.remove(sent_packet.packet_number)
~~~

# Security Considerations
Expand Down