Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use largest acknowledged consistently #1611

Merged
merged 2 commits into from
Jul 31, 2018
Merged

Conversation

ianswett
Copy link
Contributor

No description provided.

@martinthomson
Copy link
Member

I find "largest acknowledged" to be easier to read. And it avoids us using made up words.

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -recovery labels Jul 31, 2018
@ianswett
Copy link
Contributor Author

The transport draft seems to consistently use acknowledged, so I changed recovery to use that.

@ianswett ianswett changed the title Use largest_acked consistently Use largest acknowledged consistently Jul 31, 2018
@ianswett ianswett merged commit b3a05eb into master Jul 31, 2018
@martinthomson martinthomson deleted the ianswett-largest-acked branch July 31, 2018 23:53
martinthomson pushed a commit that referenced this pull request Aug 1, 2018
Use largest acknowledged consistently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants