Explicitly permit starting over #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generating a new cryptographic handshake message is a fine response to Retry or Version Negotiation. It's sometimes necessary, but even when it is not, it avoids having to worry about 0-RTT packet numbers. Followup for #1498.
ekr
approved these changes
Aug 1, 2018
| @@ -806,7 +806,8 @@ A client MUST NOT reset the packet number it uses for 0-RTT packets. The keys | |||
| used to protect 0-RTT packets will not change as a result of responding to a | |||
| Retry or Version Negotiation packet unless the client also regenerates the | |||
| cryptographic handshake message. Sending packets with the same packet number in | |||
| that case would compromise the packet protection for all 0-RTT packets. | |||
| that case could compromise the packet protection for all 0-RTT packets because | |||
There was a problem hiding this comment.
Why the change from "would" to "could". Could seems a lot more likely.
There was a problem hiding this comment.
It's not guaranteed - if the exact same data is sent again, then there is no compromise. And, from what I know of some implementations, that might even work. But it's a long shot. I'll tweak it to change emphasis.
ianswett
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating a new cryptographic handshake message is a fine response to
Retry or Version Negotiation. It's sometimes necessary, but even when
it is not, it avoids having to worry about 0-RTT packet numbers.
Followup for #1498.