Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rules for discarding old keys #1636

Merged
merged 3 commits into from Aug 14, 2018
Merged

Rules for discarding old keys #1636

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19dffbd
Rules for discarding old keys
martinthomson Aug 7, 2018
16e9226
Editorial comments from Mike
martinthomson Aug 8, 2018
59df9a5
'And when it all', ooooo
martinthomson Aug 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions draft-ietf-quic-tls.md
View file
Open in desktop
Expand Up @@ -635,8 +635,8 @@ level are available.

An endpoint cannot discard keys for a given encryption level unless it has both
received and acknowledged all CRYPTO frames for that encryption level and when
it all CRYPTO frames for that encryption level have been acknowledged by its
peer. However, this does not guarantee that no further packets will need to be
all CRYPTO frames for that encryption level have been acknowledged by its peer.
However, this does not guarantee that no further packets will need to be
received or sent at that encryption level because a peer might not have received
all the acknowledgements necessary to reach the same state.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph seems duplicative of the preceding one. Can they be consolidated? Or if they are substantially different, the difference highlighted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so. The previous paragraph is intended to highlight the reasons why keys might be retained in a general sense. The second paragraph is intended to be more precise about what the requirements are. A small tweak to the lead-in of each should help emphasize the difference.


Expand Down