Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit delayed ack timer to 1 RTT #1663

Merged
merged 3 commits into from Aug 28, 2018
Merged

Limit delayed ack timer to 1 RTT #1663

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5521fab
Limit delayed ack timer to 1 RTT
ianswett Aug 15, 2018
69278e4
Update draft-ietf-quic-transport.md
ianswett Aug 15, 2018
6f3238f
should never
ianswett Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion draft-ietf-quic-transport.md
View file
Open in desktop
Expand Up @@ -3411,7 +3411,7 @@ containing only an ACK frame per received packet that contains frames other than
an ACK frame. Packets containing non-ACK frames MUST be acknowledged
immediately or when a delayed ack timer expires. The delayed ack timer should
never delay an ACK for longer than an RTT, which ensures an ACK frame is sent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"should never" or "MUST NOT"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or "does not," if you're making an assertion about the outcome of this strategy.

at least once per RTT.
at least once per RTT if new packets needing acknowledgement were received.

To limit ACK blocks to those that have not yet been received by the sender, the
receiver SHOULD track which ACK frames have been acknowledged by its peer. Once
Expand Down