Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pad to 38 if you want a stateless reset #1682

Merged
merged 3 commits into from Aug 22, 2018
Merged

Pad to 38 if you want a stateless reset #1682

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d84fcb
Fixes #1681
martinthomson Aug 17, 2018
9b2ab7e
No exceptions on the 38 thing
martinthomson Aug 17, 2018
c8ecebb
At least, as suggested
martinthomson Aug 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Expand Up @@ -2733,8 +2733,8 @@ a small packet might result in Stateless Reset not being useful in detecting
cases of broken connections where only very small packets are sent; such
failures might only be detected by other means, such as timers.

An endpoint that wants to improve the chances that it triggers a Stateless Reset
when its peer loses state can pad all packets it sends to 38 octets.
An endpoint can increase the odds that a packet will trigger a Stateless Reset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does increasing it above 38 not ensure it will trigger a Stateless Reset? If so, I'd prefer "An endpoint can ensure that a packet will trigger..."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would hope that stateless reset is an optional feature and when it is on, resets can be send at senders discretion, e.g. implementing rate limiting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikkelfj is right, this doesn't guarantee that you get a stateless reset. The point here is that the odds of receiving one for packets below 38 octets is much lower.

if it cannot be processed by padding it to at least 38 octets.


# Frame Types and Formats
Expand Down