Remove redundant word #1692
Merged
Remove redundant word #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeBishop
requested changes
Aug 23, 2018
draft-ietf-quic-http.md
Outdated
| @@ -384,7 +384,7 @@ state), the proxy will set the FIN bit on its connection to the TCP server. When | |||
| the proxy receives a packet with the FIN bit set, it will terminate the send | |||
| stream that it sends to client. TCP connections which remain half-closed in a | |||
| single direction are not invalid, but are often handled poorly by servers, so | |||
| clients SHOULD NOT cause send a STREAM frame with a FIN bit for connections on | |||
| clients SHOULD NOT send a STREAM frame with a FIN bit for connections on | |||
There was a problem hiding this comment.
This probably needs more words, not fewer. The HTTP layer doesn't directly send STREAM frames, which is why there's a "cause" in there. Maybe "clients SHOULD NOT close a stream for sending for streams on which they still expect to receive data from the target of the CONNECT"?
martinthomson
added
editorial
MikeBishop
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.