Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nits in transport draft #1698

Merged
merged 2 commits into from Aug 24, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 9 additions & 8 deletions draft-ietf-quic-transport.md
Expand Up @@ -93,8 +93,9 @@ informative:
--- abstract

This document defines the core of the QUIC transport protocol. This document
describes connection establishment, packet format, multiplexing and reliability.
Accompanying documents describe the cryptographic handshake and loss detection.
describes connection establishment, packet format, multiplexing, and
reliability. Accompanying documents describe the cryptographic handshake and
loss detection.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a minute to find the added comma.



--- note_Note_to_Readers
Expand Down Expand Up @@ -376,7 +377,7 @@ packet type. Type-specific semantics for this version are described in the
following sections.

The end of the packet is determined by the Length field. The Length field
covers the both the Packet Number and Payload fields, both of which are
covers both the Packet Number and Payload fields, both of which are
confidentiality protected and initially of unknown length. The size of the
Payload field is learned once the packet number protection is removed.

Expand Down Expand Up @@ -1166,7 +1167,7 @@ The Frame Type field uses a variable length integer encoding (see
{{integer-encoding}}) with one exception. To ensure simple and efficient
implementations of frame parsing, a frame type MUST use the shortest possible
encoding. Though a two-, four- or eight-octet encoding of the frame types
defined in this document is possible, the Frame Type field for these frames are
defined in this document is possible, the Frame Type field for these frames is
encoded on a single octet. For instance, though 0x4007 is a legitimate
two-octet encoding for a variable-length integer with a value of 7, PING frames
are always encoded as a single octet with the value 0x07. An endpoint MUST
Expand Down Expand Up @@ -1197,7 +1198,7 @@ connection establishment intertwines version negotiation with the cryptographic
and transport handshakes to reduce connection establishment latency, as
described in {{handshake}}. Once established, a connection may migrate to a
different IP or port at either endpoint, due to NAT rebinding or mobility, as
described in {{migration}}. Finally a connection may be terminated by either
described in {{migration}}. Finally, a connection may be terminated by either
endpoint, as described in {{termination}}.

## Connection ID
Expand Down Expand Up @@ -4814,9 +4815,9 @@ sent packets match the encryption level of the sent packet. This mitigation is
useful if the connection has an ephemeral forward-secure key that is generated
and used for every new connection. If a packet sent is protected with a
forward-secure key, then any acknowledgments that are received for them MUST
also be forward-secure protected. Since the attacker will not have the forward
secure key, the attacker will not be able to generate forward-secure protected
packets with ACK frames.
also be forward-secure protected. Since the attacker will not have the
forward-secure key, the attacker will not be able to generate forward-secure
protected packets with ACK frames.


## Optimistic ACK Attack
Expand Down