Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateless reset is now available to both peers #1735

Merged
merged 1 commit into from Sep 11, 2018
Merged

Conversation

martinthomson
Copy link
Member

Also, don't create the impression that stateless reset can be used when
a packet can't be decrypted.

Closes #1728.

Also, don't create the impression that stateless reset can be used when
a packet can't be decrypted.

Closes #1728.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Sep 10, 2018
@rpaulo
Copy link
Contributor

rpaulo commented Sep 10, 2018

Thanks @martinthomson, this looks great.

@@ -1278,6 +1278,9 @@ IDs, QUIC processes the packet as part of that connection. Endpoints MUST drop
packets with zero-length Destination Connection ID fields if they do not
correspond to a single connection.

Endpoints SHOULD send a Stateless Reset ({{stateless-reset}}) for any packets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be restricted to short-header packets, correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have text in the Stateless Reset section saying an endpoint MAY send a stateless reset for a LH packet. I can't really understand how an implementation would do that, though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's not reiterate that discussion. Right now, it's basically impossible to except in a very narrow window during the handshake, but we agreed that there was no reason not to allow it. If the long header is used after the handshake completes (for reasons we come up with later), then we don't have to worry about stateless reset.

@martinthomson martinthomson merged commit 15d5f4f into master Sep 11, 2018
@martinthomson martinthomson deleted the issue1728 branch September 11, 2018 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants