Merge ACK and ACK_ECN #1801
Merged
Merge ACK and ACK_ECN #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draft-ietf-quic-transport.md
Outdated
|
|
||
| Gap and ACK Block fields use a relative integer encoding for efficiency. Though | ||
| each encoded value is positive, the values are subtracted, so that each ACK | ||
| Block describes progressively lower-numbered packets. As long as contiguous | ||
| ranges of packets are small, the variable-length integer encoding ensures that | ||
| each range can be expressed in a small number of octets. | ||
|
|
||
| The ACK frame uses the least significant bit(type=0x1b) to indicate ECN feedback |
There was a problem hiding this comment.
"bit (that is, type 0x1b)"
draft-ietf-quic-transport.md
Outdated
| Receivers send ACK frames (type=0x0d) to inform senders which packets they have | ||
| received and processed. The ACK frame contains any number of ACK blocks. | ||
| ACK blocks are ranges of acknowledged packets. | ||
| Receivers send ACK frames (types=0x1a - 0x1b) to inform senders of packets they |
draft-ietf-quic-transport.md
Outdated
| received and processed. The ACK frame contains any number of ACK blocks. | ||
| ACK blocks are ranges of acknowledged packets. | ||
| Receivers send ACK frames (types=0x1a - 0x1b) to inform senders of packets they | ||
| have received and processed. The ACK frame contains one or more ACK blocks. ACK |
There was a problem hiding this comment.
should we be capitalizing the B in ACK Blocks?
|
I decided against the big renumber. I thought it'd be best done interactively by 2 or 3 people together. Block wasn't consistently capitalized, so I made it so everywhere. |
|
Any other comments? Martin or Jana, would you be willing to merge this? |
alagoutte
added a commit
to alagoutte/base-drafts
that referenced
this pull request
Sep 30, 2018
- Merge ACK and ACK_ECN (quicwg#1801) - Add 2 transport parameters: max_ack_delay(12) and original_connection_id(13) (quicwg#981, quicwg#1710, quicwg#1486) - Remove sequence field from NEW_CONNECTION_ID (quicwg#1742) - Add RETIRE_CONNECTION_ID type (quicwg#1742)
MikeBishop
pushed a commit
that referenced
this pull request
Oct 2, 2018
MikeBishop
pushed a commit
that referenced
this pull request
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1778
Also changes the type value for ACK, ACK_ECN, and RETIRE_CONNECTION_ID in order to give the ACK frame two adjacent values.