Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handshake deadlock #1824

Merged
merged 9 commits into from
Oct 2, 2018
Merged

Handshake deadlock #1824

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
af5c415
Handshake deadlock
ianswett Oct 2, 2018
3c2c305
Update draft-ietf-quic-transport.md
ianswett Oct 2, 2018
6251bcf
Update draft-ietf-quic-transport.md
ianswett Oct 2, 2018
3ccf315
Update draft-ietf-quic-transport.md
ianswett Oct 2, 2018
ea331de
Update draft-ietf-quic-transport.md
ianswett Oct 2, 2018
165e36d
Update draft-ietf-quic-transport.md
ianswett Oct 2, 2018
fba810b
Update draft-ietf-quic-transport.md
ianswett Oct 2, 2018
a3a2299
Update draft-ietf-quic-transport.md
ianswett Oct 2, 2018
761fdf7
nit
janaiyengar Oct 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,9 +884,9 @@ the Handshake keys. This limit exists to mitigate amplification attacks.
In order to prevent this limit causing a handshake deadlock, the client SHOULD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is SHOULD sufficient? I feel like this a MUST, or compliant implementations will never complete under certain otherwise recoverable loss scenarios. Perhaps the recovery draft is more strict?

always send a packet upon a handshake timeout, as described in
{{QUIC-RECOVERY}}. If the client has no data to retransmit and does not have
Handshake keys, it should send a packet as large as the Initial containing
only PADDING. If the client has Handshake keys, it SHOULD send a packet
containing only PADDING.
Handshake keys, it SHOULD send an Initial packet of at least 1200 octets
containing only PADDING. If the client has Handshake keys, it SHOULD send a
Handshake packet containing only PADDING.

The payload of this packet contains CRYPTO frames and could contain PADDING, or
ACK frames. Handshake packets MAY contain CONNECTION_CLOSE or APPLICATION_CLOSE
Expand Down