Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename is_handshake_packets in quic-recovery #1842

Closed
wants to merge 1 commit into from
Closed

Rename is_handshake_packets in quic-recovery #1842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Expand Up @@ -651,7 +651,7 @@ are as follows:
* in_flight: A boolean that indicates whether the packet counts towards
bytes in flight.

* is_handshake_packet: A boolean that indicates whether the packet contains
* is_crypto_packet: A boolean that indicates whether the packet contains
cryptographic handshake messages critical to the completion of the QUIC
handshake. In this version of QUIC, this includes any packet with the long
header that includes a CRYPTO frame.
Expand All @@ -663,14 +663,14 @@ Pseudocode for OnPacketSent follows:

~~~
OnPacketSent(packet_number, ack_only, in_flight,
is_handshake_packet, sent_bytes):
is_crypto_packet, sent_bytes):
largest_sent_packet = packet_number
sent_packets[packet_number].packet_number = packet_number
sent_packets[packet_number].time = now
sent_packets[packet_number].ack_only = ack_only
sent_packets[packet_number].in_flight = in_flight
if !ack_only:
if is_handshake_packet:
if is_crypto_packet:
time_of_last_sent_handshake_packet = now
time_of_last_sent_retransmittable_packet = now
OnPacketSentCC(sent_bytes)
Expand Down