Move server send limitations #1843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianswett
approved these changes
Oct 8, 2018
| the Handshake keys. This limit exists to mitigate amplification attacks. | ||
|
|
||
| In order to prevent this limit causing a handshake deadlock, the client SHOULD | ||
| always send a packet upon a handshake timeout, as described in |
There was a problem hiding this comment.
Should this be "crypto handshake timeout" now?
There was a problem hiding this comment.
Bump. Also, I'm not sure what the status of this is now that the restructure PR is outstanding?
There was a problem hiding this comment.
How exactly is number of bytes measures?
|
Can you rebase this to #1857? Alternatively, wait a bit until that PR lands and then update this PR. |
|
@janaiyengar I'm happy to either do this when you submit #1857, or you could just incorporate the change (with @ianswett 's nit) directly into that PR and close this one. It's up to you. |
|
Integrated already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This text was in the "Handshake Packet" section but it applies to Handshake and Initial Packets, so I moved it.
Together with PR #1842, this resolves #1836.