Parenthesize 2 * MaxEntries to prevent naive errors #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 12, 2018 15:08
Transcribing LargestReference mod 2*MaxEntries + 1 to C one of its offspring without parentheses around 2 * MaxEntries will produce an incorrect result.
draft-ietf-quic-qpack.md
Outdated
| @@ -718,15 +718,15 @@ safe to process the rest of the block. If Largest Reference is greater than | |||
| zero, the encoder transforms it as follows before encoding: | |||
|
|
|||
| ~~~ | |||
| LargestReference = LargestReference mod 2*MaxEntries + 1 | |||
| LargestReference = LargestReference mod (2*MaxEntries) + 1 | |||
There was a problem hiding this comment.
Do you mean LR % ((2*ME)+1) or (LR % (2*ME))+1? I think the latter, but I think that it's probably best to double-down on the parentheses here.
There was a problem hiding this comment.
I mean the latter. I can add more parentheses.
martinthomson
approved these changes
Oct 19, 2018
martinthomson
added
editorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transcribing
to C one of its offspring without parentheses around 2 * MaxEntries
will produce an incorrect result.