Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: High-level restructure of transport draft #1857

Merged
merged 30 commits into from
Oct 18, 2018
Merged

WIP: High-level restructure of transport draft #1857

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
5ebd7ca
Moved stream stuff up and added intro text to describe structure of doc
janaiyengar Oct 12, 2018
c705fc1
Moved major sections around.
janaiyengar Oct 13, 2018
c4ce2c2
created packets and frames section and moved things about
janaiyengar Oct 13, 2018
438b965
modified intro, made error codes first level section
janaiyengar Oct 16, 2018
53f0bad
Done through connection migration section
janaiyengar Oct 16, 2018
9600d97
addresses mt's comments.
janaiyengar Oct 18, 2018
209a269
detailed structure in intro
janaiyengar Oct 18, 2018
d927b6a
most of martinduke comments
janaiyengar Oct 18, 2018
af51da7
added initial values in flow control
janaiyengar Oct 18, 2018
d5a1e49
lint
janaiyengar Oct 18, 2018
db2e9b2
max_stream_id
martinthomson Oct 18, 2018
ca49ae4
parenthesize
janaiyengar Oct 18, 2018
0368ca9
parenthesize
martinthomson Oct 18, 2018
1d4f7d3
stream-id-blocked frame
martinthomson Oct 18, 2018
c3426ee
s/intertwines/combines
martinthomson Oct 18, 2018
140a9c6
unnecessary text
martinthomson Oct 18, 2018
23d95c3
connection id para
martinthomson Oct 18, 2018
d3cf19f
connection id contd
martinthomson Oct 18, 2018
4c9858f
connection id contd
martinthomson Oct 18, 2018
0dfa885
s/subsequent/additional
martinthomson Oct 18, 2018
a6262f9
shorter sentences
martinthomson Oct 18, 2018
b90815f
packet protection TODO
martinthomson Oct 18, 2018
bbb241e
packet protection TODO contd
martinthomson Oct 18, 2018
2a00e0b
s/the/a
martinthomson Oct 18, 2018
2986d5b
s/acks/acknowledges
martinthomson Oct 18, 2018
c631c31
unnecessary text
martinthomson Oct 18, 2018
6a980bf
unnecessary text
martinthomson Oct 18, 2018
d6c9267
last of mt's comments
janaiyengar Oct 18, 2018
e13b6b3
lint
janaiyengar Oct 18, 2018
dd74eda
lint
janaiyengar Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,9 @@ to two levels of flow control in QUIC:
* Connection flow control, which prevents senders from exceeding a receiver's
buffer capacity for the connection, and

A data receiver sets initial credits for all streams by sending transport
parameters during the handshake ({{transport-parameters}}).

A data receiver sends MAX_STREAM_DATA or MAX_DATA frames to the sender to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a paragraph here that goes like this:

"Endpoints SHOULD communicate initial values for stream and connection flow control using transport parameters {#transport-params}. Data senders MUST use a value of zero for limits not advertised in the peer's transport parameters."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The paragraph above looks good enough to me. I don't think we need to set defaults (if this were the only thing that is read, a reader would (mostly correctly) infer that the values are always set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added that paragraph based on martinduke's comment, and yes, I agree that we don't need to recommend setting defaults.

advertise additional credit. MAX_STREAM_DATA frames send the maximum absolute
byte offset of a stream, while MAX_DATA frames send the maximum of the sum of
Expand Down