Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amplification limit in recovery #1862

Merged
merged 10 commits into from Oct 21, 2018
Merged

Amplification limit in recovery #1862

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d2c9ae5
Amplification limit in recovery
ianswett Oct 17, 2018
0cc808b
Update draft-ietf-quic-recovery.md
ianswett Oct 17, 2018
1730b2d
Update draft-ietf-quic-recovery.md
martinthomson Oct 17, 2018
e7c83d2
Crypto retransmission timer
ianswett Oct 17, 2018
360869e
Update draft-ietf-quic-recovery.md
ianswett Oct 17, 2018
97f8bf2
Update draft-ietf-quic-recovery.md
ianswett Oct 17, 2018
b523410
Client always sends
ianswett Oct 18, 2018
289a942
Update draft-ietf-quic-recovery.md
martinthomson Oct 19, 2018
d2f45ff
Update draft-ietf-quic-recovery.md
martinthomson Oct 19, 2018
dd7fc95
Update draft-ietf-quic-recovery.md
martinthomson Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion draft-ietf-quic-recovery.md
View file
Open in desktop
Expand Up @@ -322,7 +322,7 @@ When crypto packets are sent, the sender SHOULD set a timer for the crypto
timeout period. Upon timeout, the sender MUST retransmit all unacknowledged
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
timeout period. Upon timeout, the sender MUST retransmit all unacknowledged
retransmission interval. Upon timeout, the sender MUST retransmit all unacknowledged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc uses timeout and timeout period fairly consistently, so I'd like to keep it as is.

CRYPTO data if possible.

If the server has not confirmed the path, it must not send more than 3
Until the server has confirmed the path, it must not send more than 3
ianswett marked this conversation as resolved.
Show resolved Hide resolved
times the number of received bytes, as specified in the {{QUIC-TRANSPORT}}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this MUST NOT? You might avoid duplicating the requirement by saying that the server is limited in the amount of data it can send, as specified in {{QUIC-TRANSPORT}}.

If not all unacknowledged CRYPTO data can be sent, then all CRYPTO data in
Initial encryption should be retransmitted. If no bytes may be sent,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "in the Initial encryption level" or "in Initial packets"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, probably Initial packets.

Expand Down