New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ECN section #1896
Move ECN section #1896
Conversation
This moves the section under packetization and reliability. I've also added subsections, splitting out the feedback system (which is simple) with the verification stuff (which is less so).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. A few minor comments.
|
||
### ECN Verification | ||
|
||
Each endpoint independently verifies and enables use of ECN by setting the IP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should say something about when this verification can be done. It can be done any time during the connection, but it might make the most sense to do it along with the handshake. We may want to add some retransmission suggestions: if a handshake packet is detected as lost then send the retransmission without ECT bits. (Feel free to add a TODO here if you don't want to address this in this PR.)
I'm also wondering if we should add a fwd reference in the handshake section to here, with something like "An endpoint MAY combine the cryptographic handshake with ECN verification, as described in {{}}".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to take other PRs as a follow-on. Note that this is literally reordering text, so correcting any omission is strictly improvements on this.
Co-Authored-By: martinthomson <martin.thomson@gmail.com>
Co-Authored-By: martinthomson <martin.thomson@gmail.com>
This moves the section under packetization and reliability.
I've also added subsections, splitting out the feedback system (which is
simple) with the verification stuff (which is less so).