Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ECN section #1896

Merged
merged 3 commits into from Oct 23, 2018
Merged

Move ECN section #1896

merged 3 commits into from Oct 23, 2018

Conversation

martinthomson
Copy link
Member

This moves the section under packetization and reliability.
I've also added subsections, splitting out the feedback system (which is
simple) with the verification stuff (which is less so).

This moves the section under packetization and reliability.
I've also added subsections, splitting out the feedback system (which is
simple) with the verification stuff (which is less so).
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Oct 22, 2018
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. A few minor comments.

draft-ietf-quic-transport.md Outdated Show resolved Hide resolved
draft-ietf-quic-transport.md Outdated Show resolved Hide resolved

### ECN Verification

Each endpoint independently verifies and enables use of ECN by setting the IP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should say something about when this verification can be done. It can be done any time during the connection, but it might make the most sense to do it along with the handshake. We may want to add some retransmission suggestions: if a handshake packet is detected as lost then send the retransmission without ECT bits. (Feel free to add a TODO here if you don't want to address this in this PR.)

I'm also wondering if we should add a fwd reference in the handshake section to here, with something like "An endpoint MAY combine the cryptographic handshake with ECN verification, as described in {{}}".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to take other PRs as a follow-on. Note that this is literally reordering text, so correcting any omission is strictly improvements on this.

janaiyengar and others added 2 commits October 23, 2018 15:20
Co-Authored-By: martinthomson <martin.thomson@gmail.com>
Co-Authored-By: martinthomson <martin.thomson@gmail.com>
@martinthomson martinthomson merged commit fd88f99 into master Oct 23, 2018
@martinthomson martinthomson deleted the move-ecn branch October 26, 2018 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants