Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatible version upgrade #1901

Closed
wants to merge 30 commits into from
Closed

Compatible version upgrade #1901

wants to merge 30 commits into from

Commits on Oct 24, 2018

  1. Compatible version upgrade 

    This introduces the design that proposed by ekr prior to the NY interim.
In this design, the client advertises the list of versions it supports
in its transport parameters.  The server is permitted to select a
"compatible" version and proceed as though the client selected that
version.

The main advantage of this approach is seamless upgrade between
compatible versions without the extra round-trip imposed by Version
Negotiation.  This will be especially useful when we move from
pre-release versions (0xff0000xx) to the final version.

Closes #1773, #1755.
    @martinthomson
    martinthomson committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    4dc5e0d View commit details
    Browse the repository at this point in the history

  2. There are only two things, which means no list

    @martinthomson
    martinthomson committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    7483395 View commit details
    Browse the repository at this point in the history

  3. Marten's editorial suggestions

    @martinthomson
    martinthomson committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    f997b10 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2018

  1. Thwart downgrade attacks between incompatible versions 

    This complicates things slightly more.  The client has to order its
supported versions strictly (and respect that ordering in its selection
of versions).  The server has to validate things more carefully.

I have an algorithm for validation in comments, I'm interested in
whether that is worth putting in the draft.
    @martinthomson
    martinthomson committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    f12becd View commit details
    Browse the repository at this point in the history

  2. unplural 

    Co-Authored-By: martinthomson <martin.thomson@gmail.com>
    @nibanks @martinthomson
    nibanks and martinthomson committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    4235f75 View commit details
    Browse the repository at this point in the history

  3. article 

    Co-Authored-By: martinthomson <martin.thomson@gmail.com>
    @nibanks @martinthomson
    nibanks and martinthomson committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    0e0df73 View commit details
    Browse the repository at this point in the history

  4. joiner 

    Co-Authored-By: martinthomson <martin.thomson@gmail.com>
    @nibanks @martinthomson
    nibanks and martinthomson committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    48ae25f View commit details
    Browse the repository at this point in the history

  5. Nick's suggestions

    @martinthomson
    martinthomson committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    87bcb71 View commit details
    Browse the repository at this point in the history

  6. No common versions means fail 

    Closes #1917.
    @martinthomson
    martinthomson committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    847445b View commit details
    Browse the repository at this point in the history

  7. Move some text up to get the flow right

    @martinthomson
    martinthomson committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    7533873 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2018

  1. Split into supported and unsupported

    @martinthomson
    martinthomson committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    2b02ccd View commit details
    Browse the repository at this point in the history

  2. The packet definitely always changes

    @martinthomson
    martinthomson committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    34b19da View commit details
    Browse the repository at this point in the history

  3. Moar words about what it means for a version to be supported by a client

    @martinthomson
    martinthomson committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    a2c5c6a View commit details
    Browse the repository at this point in the history

  4. Cleanup, don't create conflicting requirements

    @martinthomson
    martinthomson committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    0de8a0c View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2018

  1. discard, not ignore 

    Co-Authored-By: martinthomson <martin.thomson@gmail.com>
    @igorlord @martinthomson
    igorlord and martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    8ffb306 View commit details
    Browse the repository at this point in the history

  2. Fix the RETIRE_CONNECTION_ID frame type again

    @martinthomson
    martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    67a815e View commit details
    Browse the repository at this point in the history

  3. Don't recommend stateless reset 

    Closes #1858.
    @martinthomson
    martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    4edf5b3 View commit details
    Browse the repository at this point in the history

  4. Add missing sections to document structure 

    There were two things that we missed, which looked a little incongrous.
This adds them to avoid the confusion arising from their absence, even
if they don't really need to be there.

Closes #1894.
    @martinthomson
    martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    4417e03 View commit details
    Browse the repository at this point in the history

  5. Forward reference ECN verification 

    Closes #1898.
    @martinthomson
    martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    8f69ad1 View commit details
    Browse the repository at this point in the history

  6. Take suggestion

    @martinthomson
    martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    7c4b04d View commit details
    Browse the repository at this point in the history

  7. Use octets rather than bytes throughout 

    Also closes #1863.
    @martinthomson
    martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    270243e View commit details
    Browse the repository at this point in the history

  8. Use octets for units; size for packet sizes

    @martinthomson
    martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    0143d41 View commit details
    Browse the repository at this point in the history

  9. Use bytes instead of octets throughout

    @martinthomson
    martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    bbf55a5 View commit details
    Browse the repository at this point in the history

  10. Reflow

    @martinthomson
    martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    a4f4c9f View commit details
    Browse the repository at this point in the history

  11. Update draft-ietf-quic-recovery.md 

    Co-Authored-By: martinthomson <martin.thomson@gmail.com>
    @ianswett @martinthomson
    ianswett and martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    9d50417 View commit details
    Browse the repository at this point in the history

  12. clarify 

    Co-Authored-By: martinthomson <martin.thomson@gmail.com>
    @ianswett @martinthomson
    ianswett and martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    3f330f6 View commit details
    Browse the repository at this point in the history

  13. unhypenate - the name of my new startup

    @martinthomson
    martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    f0b5080 View commit details
    Browse the repository at this point in the history

  14. rewrap

    @martinthomson
    martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    4578287 View commit details
    Browse the repository at this point in the history

  15. Reflow

    @martinthomson
    martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    aa3ddc1 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'master' into vn-mkII

    @martinthomson
    martinthomson committed Oct 29, 2018
    Configuration menu
    Copy the full SHA
    d59f429 View commit details
    Browse the repository at this point in the history