Fix type value for RETIRE_CONNECTION_ID frame #1903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udippant
force-pushed
the
fix_retire_connid_type
branch
from
f9af19b
to
a28faa1
Compare
|
Oops, already fixed this. Thanks for the PR. |
|
Thanks for fixing. This typo did indeed confuse me for several minutes ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct frame type value for RETIRE_CONNECTION_ID, as listed in page 63 (https://tools.ietf.org/html/draft-ietf-quic-transport-16#page-63) is 0x0d. However, in the section that describes the structure of RETIRE_CONNECTION_ID, it says 0x1b, which is conflicts with the type values for Ack Frame.