Renumber frames #1945
Merged
Renumber frames #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For rationale, see https://docs.google.com/spreadsheets/d/1G73qp-GBhXGyKEsZBudzWJY85FSa5txT4MxtVC5ajiE/edit#gid=0 Note that this isn't 100% mechanical. There are some other minor changes: Frames with multiple codepoints are not referred to in the plural in their first mention (because we talk about multiple frame types), and ahead of the figure that shows the fields. I have made the text announcing the figure, and the text announcing the fields consistent. There was a grammatical error (the very last change here).
martinthomson
force-pushed
the
renumber-frames
branch
from
c87a35a
to
15c59e1
Compare
| @@ -2698,24 +2698,24 @@ frames are explained in more detail in {{frame-formats}}. | |||
| | Type Value | Frame Type Name | Definition | | |||
| |:------------|:---------------------|:-------------------------------| | |||
| | 0x00 | PADDING | {{frame-padding}} | | |||
There was a problem hiding this comment.
Considering that CONNECTION_CLOSE has a frame type field, where 0x0 means that the error is not frame related, wouldn't it make sense to not use 0x0 at all for frames.
There was a problem hiding this comment.
0 was used for padding intentionally. calloc() and write-in-place implementations are easier this way.
janaiyengar
reviewed
Nov 3, 2018
janaiyengar
reviewed
Nov 3, 2018
janaiyengar
reviewed
Nov 3, 2018
janaiyengar
reviewed
Nov 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For rationale, see this spreadsheet
Note that this isn't 100% mechanical. There are some other minor
changes:
Frames with multiple codepoints are not referred to in the plural in
their first mention (because we talk about multiple frame types), and
ahead of the figure that shows the fields.
I have made the text announcing the figure, and the text announcing the
fields consistent.
There was a grammatical error (the very last change here).