Late alarms and max_ack_delay #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draft-ietf-quic-transport.md
Outdated
| sending acknowledgments. This value should include the receiver's expected | ||
| delays in alarms firing. For example, if a receiver specifies a 5ms | ||
| max_ack_delay and alarms commonly fire up to 1ms late, then it should set | ||
| a timer for 4ms. If this value is absent, a default of 25 milliseconds is |
There was a problem hiding this comment.
I would do this the other way around. If a receiver sets ack delay timers at 5ms and alarms could fire up to 1ms late, then it should advertise a max_ack_delay of 6ms.
martinthomson
added
editorial
|
Martin, thanks of fixing this up and landing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some text on how to correctly specify max_ack_delay on systems where the alarm may fire late.