Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery uses both time and packet thresholds #1974

Merged
merged 27 commits into from
Dec 4, 2018
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
8ad3cab
Recovery uses both time and packet thresholds
ianswett Nov 6, 2018
4367f31
Merge branch 'master' into ianswett-both-thresholds
ianswett Nov 6, 2018
aea6a42
Update draft-ietf-quic-recovery.md
ianswett Nov 6, 2018
51ebc20
Update draft-ietf-quic-recovery.md
ianswett Nov 6, 2018
c23f901
Update draft-ietf-quic-recovery.md
ianswett Nov 6, 2018
c98a79c
Update draft-ietf-quic-recovery.md
ianswett Nov 7, 2018
cd05b45
Update draft-ietf-quic-recovery.md
ianswett Nov 7, 2018
1c2596e
Update draft-ietf-quic-recovery.md
ianswett Nov 7, 2018
52aa21a
Update draft-ietf-quic-recovery.md
ianswett Nov 7, 2018
21635b4
Update draft-ietf-quic-recovery.md
ianswett Nov 20, 2018
5afcc2a
Update draft-ietf-quic-recovery.md
ianswett Nov 30, 2018
d606f71
Update draft-ietf-quic-recovery.md
ianswett Nov 30, 2018
fd835fa
Update draft-ietf-quic-recovery.md
ianswett Nov 30, 2018
561e227
Update draft-ietf-quic-recovery.md
ianswett Nov 30, 2018
7560bb4
Update draft-ietf-quic-recovery.md
ianswett Nov 30, 2018
c3bc7bb
Merge branch 'master' into ianswett-both-thresholds
ianswett Nov 30, 2018
ddfe711
Update draft-ietf-quic-recovery.md
ianswett Nov 30, 2018
86cb551
Editorial rework
janaiyengar Dec 1, 2018
e8ae5ad
lint
janaiyengar Dec 1, 2018
6ad1106
clean up RACK reference
janaiyengar Dec 1, 2018
1088bb6
more changes
janaiyengar Dec 1, 2018
8a695c9
Update draft-ietf-quic-recovery.md
ianswett Dec 4, 2018
006843e
Ian comments
janaiyengar Dec 4, 2018
d095952
edit
janaiyengar Dec 4, 2018
000f612
lint
janaiyengar Dec 4, 2018
8b42d95
Merge pull request #2080 from quicwg/editorial-changes
janaiyengar Dec 4, 2018
a06d679
small fix
janaiyengar Dec 4, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions draft-ietf-quic-recovery.md
Original file line number Diff line number Diff line change
Expand Up @@ -274,19 +274,14 @@ TCP-NCR {{?RFC4653}}, to improve QUIC's reordering resilience.
Time threshold loss detection uses a time threshold to determine how much
reordering to tolerate. In this document, the threshold is expressed as a
fraction of an RTT, but implemenantations MAY experiment with absolute
thresholds. This may be used either as a replacement for a packet reordering
threshold or in addition to it.

When a larger packet is acknowledged, if it was sent more than the threshold
after any in flight packets, those packets are immediately declared lost.
Otherwise, a timer is set for the the reordering threshold minus the time
difference between the earliest in flight packet and the largest newly
acknowledged packet. Note that in some cases the timer could become longer when
packets are acknowleged out of order. The RECOMMENDED time threshold, expressed
thresholds. It is recommended this is is used in conjunction with packet
threshold fast retransmit. The RECOMMENDED time threshold, expressed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is mostly unclear ("in conjunction with packet threshold fast retransmit") and not really useful. I would drop it entirely.

as a fraction of the round-trip time (kTimeReorderingFraction), is 1/8.

An endpoint SHOULD set the timer such that a packet is marked as lost no earlier
than 1.125 * max(SRTT, latest_RTT) since when it was sent.
An endpoint SHOULD declare packets lost no earlier than
ianswett marked this conversation as resolved.
Show resolved Hide resolved
1.125 * max(SRTT, latest_RTT) after when they were sent. If packets sent prior
to the largest acknowledged packet cannot yet be declared lost, then a timer
SHOULD be set for the remainint time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remaining


Using max(SRTT, latest_RTT) protects from the two following cases:

Expand Down