-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recovery uses both time and packet thresholds #1974
Merged
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
8ad3cab
Recovery uses both time and packet thresholds
ianswett 4367f31
Merge branch 'master' into ianswett-both-thresholds
ianswett aea6a42
Update draft-ietf-quic-recovery.md
ianswett 51ebc20
Update draft-ietf-quic-recovery.md
ianswett c23f901
Update draft-ietf-quic-recovery.md
ianswett c98a79c
Update draft-ietf-quic-recovery.md
ianswett cd05b45
Update draft-ietf-quic-recovery.md
ianswett 1c2596e
Update draft-ietf-quic-recovery.md
ianswett 52aa21a
Update draft-ietf-quic-recovery.md
ianswett 21635b4
Update draft-ietf-quic-recovery.md
ianswett 5afcc2a
Update draft-ietf-quic-recovery.md
ianswett d606f71
Update draft-ietf-quic-recovery.md
ianswett fd835fa
Update draft-ietf-quic-recovery.md
ianswett 561e227
Update draft-ietf-quic-recovery.md
ianswett 7560bb4
Update draft-ietf-quic-recovery.md
ianswett c3bc7bb
Merge branch 'master' into ianswett-both-thresholds
ianswett ddfe711
Update draft-ietf-quic-recovery.md
ianswett 86cb551
Editorial rework
janaiyengar e8ae5ad
lint
janaiyengar 6ad1106
clean up RACK reference
janaiyengar 1088bb6
more changes
janaiyengar 8a695c9
Update draft-ietf-quic-recovery.md
ianswett 006843e
Ian comments
janaiyengar d095952
edit
janaiyengar 000f612
lint
janaiyengar 8b42d95
Merge pull request #2080 from quicwg/editorial-changes
janaiyengar a06d679
small fix
janaiyengar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -274,19 +274,14 @@ TCP-NCR {{?RFC4653}}, to improve QUIC's reordering resilience. | |
Time threshold loss detection uses a time threshold to determine how much | ||
reordering to tolerate. In this document, the threshold is expressed as a | ||
fraction of an RTT, but implemenantations MAY experiment with absolute | ||
thresholds. This may be used either as a replacement for a packet reordering | ||
threshold or in addition to it. | ||
|
||
When a larger packet is acknowledged, if it was sent more than the threshold | ||
after any in flight packets, those packets are immediately declared lost. | ||
Otherwise, a timer is set for the the reordering threshold minus the time | ||
difference between the earliest in flight packet and the largest newly | ||
acknowledged packet. Note that in some cases the timer could become longer when | ||
packets are acknowleged out of order. The RECOMMENDED time threshold, expressed | ||
thresholds. It is recommended this is is used in conjunction with packet | ||
threshold fast retransmit. The RECOMMENDED time threshold, expressed | ||
as a fraction of the round-trip time (kTimeReorderingFraction), is 1/8. | ||
|
||
An endpoint SHOULD set the timer such that a packet is marked as lost no earlier | ||
than 1.125 * max(SRTT, latest_RTT) since when it was sent. | ||
An endpoint SHOULD declare packets lost no earlier than | ||
ianswett marked this conversation as resolved.
Show resolved
Hide resolved
|
||
1.125 * max(SRTT, latest_RTT) after when they were sent. If packets sent prior | ||
to the largest acknowledged packet cannot yet be declared lost, then a timer | ||
SHOULD be set for the remainint time. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remaining |
||
|
||
Using max(SRTT, latest_RTT) protects from the two following cases: | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is mostly unclear ("in conjunction with packet threshold fast retransmit") and not really useful. I would drop it entirely.