Expands CID size text just a bit #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkelfj
reviewed
Nov 15, 2018
draft-ietf-quic-transport.md
Outdated
| subsequent Initial packets are routed to the same server. | ||
| The final version used for a connection might be different from the version of | ||
| the first Initial from the client. To enable consistent routing through the | ||
| handshake, a client SHOULD select a Destination Connection ID length long enough |
There was a problem hiding this comment.
Suggested change
| handshake, a client SHOULD select a Destination Connection ID length long enough | |
| handshake, a client SHOULD select an initial Destination Connection ID length long enough |
There was a problem hiding this comment.
Note that accepting this suggestion directly on GitHub will break lint -- you'll need to rewrap.
There was a problem hiding this comment.
I gave that feedback to github on this feature - that you can handle line lengths.
martinthomson
approved these changes
Nov 19, 2018
MikeBishop
reviewed
Nov 19, 2018
MikeBishop
added
editorial
|
@MikeBishop: There's an implicit assumption though in the text about this. Are you opposed to this PR? |
|
Fair enough; this PR doesn't introduce that problem, though it magnifies it a bit. I've opened #2026 to resolve that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.