New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send an immediate ACK #2025
Merged
Merged
Send an immediate ACK #2025
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
249f152
Send a few immediate ACKs
ianswett 099dedd
Update draft-ietf-quic-recovery.md
ianswett 31d1343
Merge branch 'master' into ianswett-immediate-ack
ianswett b343e2b
Update draft-ietf-quic-recovery.md
ianswett f070e8f
Should immediately ACK one packet
ianswett 60a6255
Update draft-ietf-quic-recovery.md
ianswett cfb0ae8
Update draft-ietf-quic-recovery.md
ianswett 183d6c3
Update draft-ietf-quic-recovery.md
ianswett 87ac16a
Update draft-ietf-quic-recovery.md
ianswett fba23ef
Update draft-ietf-quic-recovery.md
ianswett ac2c595
Update draft-ietf-quic-recovery.md
ianswett 741c294
Jana's suggestion
ianswett 7e473d9
Only send immediate acks for 1/8 RTT
ianswett 8b7cb1a
A bit clearer
ianswett 2c9832b
Update draft-ietf-quic-recovery.md
ianswett d5cb783
Update draft-ietf-quic-recovery.md
ianswett File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, there are SHOULDs on top of SHOULDs here. How about this for a paragraph:
"Quicker acknowledgement of out-of-order packets may accelerate loss detection. Upon receipt of a packet number not one more than the previous maximum received, receivers SHOULD separately acknowledge it and the next few packets, but not more than five."
This is shorter, has only one SHOULD, and places a recommended limit that is less subjective than "a few".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have a reordering threshold constant we could use here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestions, I reworked the text to only have one SHOULD and mention the 1/8 RTT as the max amount of time to send immediate acks.