Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send an immediate ACK #2025

Merged
merged 16 commits into from Feb 1, 2019
Merged

Send an immediate ACK #2025

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
249f152
Send a few immediate ACKs
ianswett Nov 20, 2018
099dedd
Update draft-ietf-quic-recovery.md
ianswett Nov 20, 2018
31d1343
Merge branch 'master' into ianswett-immediate-ack
ianswett Jan 11, 2019
b343e2b
Update draft-ietf-quic-recovery.md
ianswett Jan 11, 2019
f070e8f
Should immediately ACK one packet
ianswett Jan 15, 2019
60a6255
Update draft-ietf-quic-recovery.md
ianswett Jan 15, 2019
cfb0ae8
Update draft-ietf-quic-recovery.md
ianswett Jan 15, 2019
183d6c3
Update draft-ietf-quic-recovery.md
ianswett Jan 15, 2019
87ac16a
Update draft-ietf-quic-recovery.md
ianswett Jan 15, 2019
fba23ef
Update draft-ietf-quic-recovery.md
ianswett Jan 15, 2019
ac2c595
Update draft-ietf-quic-recovery.md
ianswett Jan 15, 2019
741c294
Jana's suggestion
ianswett Jan 29, 2019
7e473d9
Only send immediate acks for 1/8 RTT
ianswett Jan 29, 2019
8b7cb1a
A bit clearer
ianswett Jan 30, 2019
2c9832b
Update draft-ietf-quic-recovery.md
ianswett Jan 30, 2019
d5cb783
Update draft-ietf-quic-recovery.md
ianswett Jan 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion draft-ietf-quic-recovery.md
View file
Open in desktop
Expand Up @@ -491,7 +491,7 @@ packet which is not one greater than the largest received packet number. The
receiver MAY send an immediate ACK when a missing packet begins exceeding the
peer's reordering threshold in packets to accelerate fast retransmit. Time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a problem, since the receiver does not know the peer's reordering threshold. Also, this sentence does not make sense "a missing packet begins exceeding ... threshold in packets"

threshold loss detection does not require any special ACK generation to
accelerate fast retransmit because it uses a timer.
accelerate fast retransmit, because it uses a timer.
ianswett marked this conversation as resolved.
Show resolved Hide resolved

Similarly, packets marked with the ECN Congestion Experienced (CE) codepoint in
the IP header SHOULD be acknowledged immediately, to reduce the peer's response
Expand Down