Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pad rather than shift the header protection offset #2030

Merged
merged 4 commits into from Nov 22, 2018
Merged

Pad rather than shift the header protection offset #2030

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d2a951
Pad rather than shift the header protection offset
martinthomson Nov 21, 2018
03d7c78
Fix stateless reset to match
martinthomson Nov 21, 2018
162d137
Hyphens an other such things
janaiyengar Nov 22, 2018
0d714e1
182 bits
martinthomson Nov 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Expand Up @@ -2263,7 +2263,7 @@ following layout:
0 1 2 3
0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
|0|1| Random Bits (190..) ...
|0|1| Random Bits (182..) ...
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
Copy link
Member

@kazuho kazuho Nov 21, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 182?

The minimum sum of length(pn) + length(payload) is 2 in the current draft. That changes to 4 in the PR. Therefore the delta is 2*8, not 3*8.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I very carefully calculated this, having first reached this conclusion (182), then recalculated and got 190. Thanks.

| |
+ +
Expand All @@ -2286,7 +2286,7 @@ number of random bytes following it are set to unpredictable values. The last

A stateless reset will be interpreted by a recipient as a packet with a short
header. For the packet to appear as valid, the Random Bits field needs to
include at least 190 bits of random or unpredictable values (or 24 bytes, less
include at least 182 bits of random or unpredictable values (or 24 bytes, less
the two fixed bits). This is intended to allow for a destination connection ID
of the maximum length permitted, with a minimal packet number, and payload. The
Stateless Reset Token corresponds to the minimum expansion of the packet
Expand Down