No RTT for non-retransmittable packets #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only take RTT samples when the largest acked is a retransmittable packet. Otherwise, the ack delay may be unlimited.
janaiyengar
reviewed
Dec 5, 2018
draft-ietf-quic-recovery.md
Outdated
| ignored. | ||
| the current time and the time the largest acked packet was sent. If the largest | ||
| acked is not newly acknowledged or not retransmittable, RTT cannot be | ||
| calculated. When RTT is calculated, the ack delay field from the ACK frame |
There was a problem hiding this comment.
I would make this normative. "An RTT sample MUST NOT be taken for a packet that is not newly acknowledged or not retransmittable."
Jana's suggestion
janaiyengar
approved these changes
Dec 6, 2018
martinthomson
added
design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only take RTT samples when the largest acked is a retransmittable packet. Otherwise, the ack delay may be unlimited.
Came up in discussion of #2060