Changelogs for -17 #2139
Merged
Changelogs for -17 #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
added
editorial
janaiyengar
approved these changes
Dec 13, 2018
|
Looks good to me. |
dtikhonov
reviewed
Dec 13, 2018
| - Removed reservation of error code 0 (#1922) | ||
| - Removed reservation of error code 0 and moved HTTP_NO_ERROR to this value | ||
| (#1922) | ||
| - Removed prohibition of zero-length DATA frames (#2098) |
There was a problem hiding this comment.
The change in PR #2098 was reverted.
There was a problem hiding this comment.
I reverted the change in definition of zero, but I kept the un-prohibition of sending zero-length frames. There seemed to be clear agreement that this was a preference, and there's no technical reason to prohibit it.
There was a problem hiding this comment.
No problem -- CONSTANT VIGILANCE!!! 😉
There was a problem hiding this comment.
Ah, right. Thanks for reverting my change @MikeBishop :-)
There was a problem hiding this comment.
See, I knew that I'd checked that :)
This reverts commit 63fd83c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure that I captured everything here.
I also discovered a few things in -recovery that I wasn't paying close attention to that looked bad. Issues raised for those.
This doesn't include #2045, though I think we agreed to merge it.