Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'time_sent' instead of 'time' consistently #2193

Merged
merged 4 commits into from Dec 16, 2018
Merged

Use 'time_sent' instead of 'time' consistently #2193

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6654eb2
Use 'time_sent' instead of 'time' consistently
ghedo Dec 15, 2018
e3b8bf3
Fix lint
janaiyengar Dec 16, 2018
b87dad3
fix formatting
janaiyengar Dec 16, 2018
91da5d4
I hate the online editor
janaiyengar Dec 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 7 additions & 6 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Expand Up @@ -541,7 +541,7 @@ sent_bytes:
: The number of bytes sent in the packet, not including UDP or IP
overhead, but including QUIC framing overhead.

time:
time_sent:
: The time the packet was sent.


Expand Down Expand Up @@ -659,7 +659,7 @@ Pseudocode for OnPacketSent follows:
is_crypto_packet, sent_bytes):
largest_sent_packet = packet_number
sent_packets[packet_number].packet_number = packet_number
sent_packets[packet_number].time = now
sent_packets[packet_number].time_sent = now
sent_packets[packet_number].ack_eliciting = ack_eliciting
sent_packets[packet_number].in_flight = in_flight
if (ack_eliciting):
Expand All @@ -683,7 +683,8 @@ Pseudocode for OnAckReceived and UpdateRtt follow:
// ack-eliciting, update the RTT.
if (sent_packets[ack.largest_acked] &&
sent_packets[ack.largest_acked].ack_eliciting):
latest_rtt = now - sent_packets[ack.largest_acked].time
latest_rtt =
now - sent_packets[ack.largest_acked].time_sent
UpdateRtt(latest_rtt, ack.ack_delay)

// Find all newly acked packets in this ACK frame
Expand Down Expand Up @@ -1080,7 +1081,7 @@ acked_packet from sent_packets.
OnPacketAckedCC(acked_packet):
// Remove from bytes_in_flight.
bytes_in_flight -= acked_packet.size
if (InRecovery(acked_packet.time)):
if (InRecovery(acked_packet.time_sent)):
// Do not increase congestion window in recovery period.
return
if (congestion_window < ssthresh):
Expand Down Expand Up @@ -1125,7 +1126,7 @@ Invoked when an ACK frame with an ECN section is received from the peer.
// Start a new congestion event if the last acknowledged
// packet was sent after the start of the previous
// recovery epoch.
CongestionEvent(sent_packets[ack.largest_acked].time)
CongestionEvent(sent_packets[ack.largest_acked].time_sent)
~~~


Expand All @@ -1143,7 +1144,7 @@ are detected lost.

// Start a new congestion epoch if the last lost packet
// is past the end of the previous recovery epoch.
CongestionEvent(largest_lost_packet.time)
CongestionEvent(largest_lost_packet.time_sent)
~~~


Expand Down