Ekr editorial 17 http #2204
Merged
Ekr editorial 17 http #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any invalid frame is handled this way, so this is redundant.
specific instance for SETTINGS.
MikeBishop
requested changes
Dec 18, 2018
draft-ietf-quic-http.md
Outdated
| @@ -324,7 +325,7 @@ transport parameter `initial_max_uni_streams`. | |||
|
|
|||
| If the stream header indicates a stream type which is not supported by the | |||
| recipient, the remainder of the stream cannot be consumed as the semantics are | |||
| unknown. Recipients of unknown stream types MAY trigger a QUIC STOP_SENDING | |||
| unknown. Recipients of unknown stream types MAY send a QUIC STOP_SENDING | |||
There was a problem hiding this comment.
The use of "trigger" is deliberate, since an HTTP implementation cannot directly send transport frames. It can ask the transport implementation to do so.
draft-ietf-quic-http.md
Outdated
| treated as a stream error of type HTTP_MALFORMED_FRAME. Likewise, a PRIORITY | ||
| frame sent on a control stream with the Prioritized Element Type set to `11` | ||
| MUST be treated as a connection error of type HTTP_MALFORMED_FRAME. | ||
| Note that unlike in {{!RFC7540}}; the root of the tree cannot be |
There was a problem hiding this comment.
I don't think this should be a semicolon.
draft-ietf-quic-qpack.md
Outdated
| @@ -312,7 +312,7 @@ permit the encoder to track the decoder's state. These events are: | |||
|
|
|||
| - Complete processing of a header block | |||
| - Abandonment of a stream which might have remaining header blocks | |||
| - Receipt of new dynamic table entries | |||
| - Receipt of new dynamic table entries (Table State Synchronize) | |||
There was a problem hiding this comment.
Why specify the instruction for this event, but not for the others? This ought to be consistent.
draft-ietf-quic-qpack.md
Outdated
| @@ -375,7 +375,7 @@ initial maximum table size is the value of the setting in the peer's SETTINGS | |||
| frame. | |||
|
|
|||
| Before a new entry is added to the dynamic table, entries are evicted from the | |||
| end of the dynamic table until the size of the dynamic table is less than or | |||
| end the dynamic table until the size of the dynamic table is less than or | |||
|
M-x set-variable fill-column 80 |
martinthomson
added
editorial
|
Oops -- I tried to merge this manually and wound up pulling junk into the branch. Fixing. |
MikeBishop
force-pushed
the
ekr_editorial_17_http
branch
from
a889946
to
23b7d6e
Compare
MikeBishop
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.