Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial maximum table size is SETTINGS_HEADER_TABLE_SIZE. #2257

Closed
wants to merge 1 commit into from
Closed

Initial maximum table size is SETTINGS_HEADER_TABLE_SIZE. #2257

wants to merge 1 commit into from

Conversation

bencebeky
Copy link
Contributor

Remove ambigous or confusing phrases "corresponding setting when HTTP requests or responses are first permitted to be sent" and "the value of the setting in the peer’s SETTINGS frame"; define initial maximum table size to be value of SETTINGS_HEADER_TABLE_SIZE sent by the decoder.

@martinthomson
Copy link
Member

martinthomson commented Dec 31, 2018

I think that I prefer this to #2256 . At least it is consistent.

@martinthomson martinthomson added design An issue that affects the design of the protocol; resolution requires consensus. -http labels Dec 31, 2018
@afrind afrind added the -qpack label Jan 10, 2019
afrind added a commit that referenced this pull request Jan 11, 2019
0-RTT client
 Use remembered value
 If 0, server can increase in SETTINGS
 otherwise server must use this value in SETTINGS

Everyone else
 Starts at 0
 Can be set to non-zero by SETTINGS

This started as a modification of #2257, but the differences were significant enough I split it off.

Fixes #2276
@bencebeky
Copy link
Contributor Author

I belive that #2330 is a cleaner and less error-prone alternative, therefore I withdraw this PR in favor of #2330.

@bencebeky bencebeky closed this Jan 23, 2019
@bencebeky bencebeky deleted the bnc-initialtablesize-setting branch January 23, 2019 01:42
afrind added a commit that referenced this pull request Feb 6, 2019
* QPACK: Clarify how maximum dynamic table capacity can be set

0-RTT client
 Use remembered value
 If 0, server can increase in SETTINGS
 otherwise server must use this value in SETTINGS

Everyone else
 Starts at 0
 Can be set to non-zero by SETTINGS

This started as a modification of #2257, but the differences were significant enough I split it off.

Fixes #2276

* Martin's comments

* Clarify 0-RTT a little more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-http -qpack design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants