New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify that INITCWND caps amount of data sent to a server before address validation #2341
clarify that INITCWND caps amount of data sent to a server before address validation #2341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that you have this backwards. The point here is that the client is limited by INITCWND. The server has to abide by the x3 rule.
@martinthomson That's definitely true. Addressed in f7b0187. |
I'm not sure if this is correct. If a packet is declared lost, it can be retransmitted, so in that case the amount of data sent is larger than initial cwnd. |
@marten-seemann That's a good point. Does changing the text to refer to "congestion avoidance algorithm" instead of "initial congestion window" resolve the concern? |
This looks fine, but I have a new concern: this makes it appear as though the congestion window doesn't apply to the server. It does. Would this be better?
|
@martinthomson Thanks. Applied in 5522bd5. |
draft-ietf-quic-transport.md
Outdated
@@ -1579,6 +1579,10 @@ the client during connection establishment with a Retry packet (see | |||
{{validate-retry}}) or in a previous connection using the NEW_TOKEN frame (see | |||
{{validate-future}}). | |||
|
|||
The amount that servers are permitted to send is also constrained by the limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: "In addition to sending limits imposed prior to address validation, servers are also constrained in what they can send by the limits set by the congestion avoidance algorithm. Clients are only constrained by the congestion avoidance algorithm."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/congestion avoidance algorithm/congestion controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ianswett @janaiyengar Thank you! Applied the suggestions.
Thanks everyone. This looks nothing like what it did when it started, but it's much clearer as a result. |
Clarifies how we prohibit a server from sending too many packets to a client prior to validating the address.
Closes #2135.