STOP_SENDING is permitted for Ready streams #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
added
editorial
...in the case where those streams are implicitly created. There's probably another state here if we were being entirely honest with ourselves to distinguish between a stream that has been created and one that has had frames sent for it, but this is already more complex than it needs to be. Closes #2345.
martinthomson
force-pushed
the
stop-sending-ready
branch
from
6dbefa7
to
c341422
Compare
dtikhonov
reviewed
Jan 21, 2019
draft-ietf-quic-transport.md
Outdated
| data is being discarded on receipt at application request. This signals a peer | ||
| to abruptly terminate transmission on a stream. | ||
| data is being discarded on receipt at application request. STOP_SENDING | ||
| requests that a peer to cease transmission on a stream. |
There was a problem hiding this comment.
"requests that" usually calls for the subjunctive mood:
...requests that a peer cease transmission...
ianswett
approved these changes
Jan 21, 2019
|
@ianswett, does this sound normal to you?
|
|
To clarify, I +1'd your suggestion. More clearly: "Looks good, but I would like you to accept Dimitri's suggestion before submitting this PR." |
|
Ah, alright. I thought it was the other way around. |
|
This LGTM. I was just about to file a similar issue when I saw this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...in the case where those streams are implicitly created. There's
probably another state here if we were being entirely honest with
ourselves to distinguish between a stream that has been created and one
that has had frames sent for it, but this is already more complex than
it needs to be.
Closes #2345.