Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bikeshed Required Insert Count encoding. #2366

Merged
merged 2 commits into from Jan 28, 2019
Merged

Bikeshed Required Insert Count encoding. #2366

merged 2 commits into from Jan 28, 2019

Conversation

bencebeky
Copy link
Contributor

  1. This makes the encoding and decoding pseudo-code more symmetric.
  2. "Alternatively" might not be the best word here, because it might imply that the implementation has a choice.
  3. In a section about encoding Required Insert Count, it is more pure to talk about Required Insert Count being zero than to talk about whether references are made to the dynamic table.

afrind
afrind reviewed Jan 28, 2019
View reviewed changes
draft-ietf-quic-qpack.md Outdated Show resolved Hide resolved
@afrind
Copy link
Contributor

afrind commented Jan 28, 2019

Also, CI failed because the line is too long

@afrind afrind added editorial An issue that does not affect the design of the protocol; does not require consensus. -qpack labels Jan 28, 2019
@afrind afrind merged commit e6b676a into quicwg:master Jan 28, 2019
@bencebeky bencebeky deleted the bnc-encode-requiredinsertcount branch January 28, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrind afrind afrind left review comments

Assignees
No one assigned
Labels
-qpack editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bencebeky @afrind