Clarify when to signal error on incorrect Required Insert Count. #2368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afrind
reviewed
Jan 28, 2019
draft-ietf-quic-qpack.md
Outdated
| @@ -253,7 +253,16 @@ received. | |||
| Each header block contains a Required Insert Count, the lowest possible value | |||
| for the Insert Count with which the header block can be decoded. For a header | |||
| block with no references to the dynamic table, the Required Insert Count is | |||
| zero. | |||
| zero. For a header block with references to the dynamic table, the Required | |||
There was a problem hiding this comment.
Maybe move this one sentence earlier, where RIC is defined?
draft-ietf-quic-qpack.md
Outdated
| dynamic table entries. | ||
|
|
||
| If the decoder encounters a header block with a Required Insert Count value | ||
| larger than defined here, it MAY treat this as a stream error of type |
afrind
added
editorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the draft is inconsistent: if the Required Insert Count value in a header block is smaller than dictated by the referenced dynamic table entries, {{overview-hol-avoidance}} says the decoder MAY treat this as a stream error, while {{invalid-references}} says it MUST. This PR seeks to clarify this.