Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packetization Nits #2476

Merged
merged 2 commits into from Feb 17, 2019
Merged

Packetization Nits #2476

merged 2 commits into from Feb 17, 2019

Conversation

martinduke
Copy link
Contributor

The deleted parenthetical is not accurate, and is unnecessary: 0-RTT and 1-RTT with various key phases share a PN space without sharing keys.

I prefer the MUST NOT in coalescing, but if there are objections I can revert it.

The deleted parenthetical is not accurate, and is unnecessary: 0-RTT and 1-RTT with various key phases share a PN space without sharing keys.

I prefer the MUST NOT in coalescing, but if there are objections I can revert it.
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good apart from the MUST NOT.

@@ -2594,7 +2594,7 @@ MUST attempt to process the remaining packets.

Retry packets ({{packet-retry}}), Version Negotiation packets
({{packet-version}}), and packets with a short header ({{short-header}}) do not
contain a Length field and so cannot be followed by other packets in the same
contain a Length field and so MUST NOT be followed by other packets in the same
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer cannot. It isn't an interoperability requirement that these not be followed by anything else, it is an outright impossibility.

Copy link
Contributor

@MikeBishop MikeBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm with Martin -- everything else looks fine.

@martinthomson martinthomson merged commit ba7b7c2 into quicwg:master Feb 17, 2019
@martinthomson
Copy link
Member

Thanks Martin.

@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants