Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close the connection if MAX_STREAMS is too large #2499

Merged
merged 9 commits into from
Mar 19, 2019
Merged

Close the connection if MAX_STREAMS is too large #2499

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4edeb3a
Close the connection if MAX_STREAMS is too large
ianswett Mar 5, 2019
b737e89
Martin/Kazuho's suggestion
ianswett Mar 7, 2019
fc64707
Update draft-ietf-quic-transport.md
ianswett Mar 7, 2019
01d7680
Update draft-ietf-quic-transport.md
janaiyengar Mar 7, 2019
74c725a
Update draft-ietf-quic-transport.md
ianswett Mar 7, 2019
1ecbbea
Update draft-ietf-quic-transport.md
ianswett Mar 7, 2019
0a7ac9f
Jana's suggestion
ianswett Mar 8, 2019
8ecbcb2
Mike's suggestion
ianswett Mar 9, 2019
1281676
Update draft-ietf-quic-transport.md
ianswett Mar 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,6 +851,12 @@ limits are set in the transport parameters (see
using MAX_STREAMS frames ({{frame-max-streams}}). Separate limits apply to
unidirectional and bidirectional streams.

If a max_streams transport parameter or MAX_STREAMS frame is received with a
value greater than 2^60, this would allow a maximum stream ID that cannot be
expressed as a variable-length integer (see {{integer-encoding}}).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better: ... this value would be larger than the maximum stream ID that can be expresed as a variable-length integer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm ok with the existing text at this point, but if others prefer yours, I'll change it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're bike-shedding the grammar, I'd vote for ... this would allow a maximum stream ID .... Using "would" correlates better to the fact that this is indeed a protocol error and therefore isn't actually allowing anything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG, done.

If either is received, the connection MUST be closed immediately with a
connection error of type STREAM_LIMIT_ERROR (see {{immediate-close}}).

Endpoints MUST NOT exceed the limit set by their peer. An endpoint that
receives a STREAM frame with a stream ID exceeding the limit it has sent MUST
treat this as a stream error of type STREAM_LIMIT_ERROR ({{error-handling}}).
Expand Down