Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define Error when Empty Bits != 0 #2501

Merged
merged 2 commits into from Apr 18, 2019
Merged

Define Error when Empty Bits != 0 #2501

merged 2 commits into from Apr 18, 2019

Conversation

martinduke
Copy link
Contributor

in the PRIORITY frame

@martinduke
Define Error when Empty Bits != 0
f6e8265 
in the PRIORITY frame
LPardue
LPardue reviewed Mar 5, 2019
View reviewed changes
Copy link
Member

@LPardue LPardue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this agrees with the field requirement that empty bits are ignored

Empty: A four-bit field which MUST be zero when sent and MUST be
ignored on receipt.

@martinthomson martinthomson added design An issue that affects the design of the protocol; resolution requires consensus. -http labels Mar 11, 2019
@martinduke martinduke mentioned this pull request Mar 20, 2019
Closed
@MikeBishop
Copy link
Contributor

I agree, this doesn't seem to mesh with the discussion on the issue. If nothing else, it introduces the inconsistency @LPardue pointed out, but the gist of the issue seems to be that a receiver MAY check that it's zero.

@martinduke
Copy link
Contributor Author

@MikeBishop Are you in favor of changing MUST to MAY, should I discard the PR, or have I misunderstood your comment completely?

@MikeBishop
Copy link
Contributor

MUST => MAY

@martinduke
Changed MUST -> MAY
1ba6510 
To address @MikeBishop's concern. I ask the editors to move this one forward if there are no further problems.
@MikeBishop MikeBishop merged commit 1ba6510 into quicwg:master Apr 18, 2019
MikeBishop added a commit that referenced this pull request Apr 18, 2019
@MikeBishop
List #2501
c271dae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPardue LPardue LPardue left review comments

Assignees
No one assigned
Labels
-http design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@martinduke @MikeBishop @LPardue @martinthomson