Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transport parameters are mandatory. Fixes #2528 #2560

Merged
merged 5 commits into from Apr 30, 2019
Merged

Transport parameters are mandatory. Fixes #2528 #2560

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af642f8
Transport parameters are mandatory. Fixes #2528
ekr Mar 27, 2019
f61cb02
Review comments
ekr Mar 27, 2019
54bd1c2
e, not d
ekr Mar 27, 2019
da01bfe
Reflow
martinthomson Mar 27, 2019
4e2709b
Merge branch 'master' into tp_mandatory
martinthomson Apr 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion draft-ietf-quic-tls.md
View file
Open in desktop
Expand Up @@ -1251,7 +1251,11 @@ quic_transport_parameters extension carries a TransportParameters struct when
the version of QUIC defined in {{QUIC-TRANSPORT}} is used.

The quic_transport_parameters extension is carried in the ClientHello and the
EncryptedExtensions messages during the handshake.
EncryptedExtensions messages during the handshake. Endpoints MUST send the
quic_transport_parameters extension; endpoints that receive ClientHello or
EncryptedExtensions messages without the quic_transport_parameters extension
MUST terminate the TLS handshake with a fatal missing_extension alert (an error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MUST terminate the TLS handshake with a fatal missing_extension alert (an error
MUST close the connection with an error of type 0x16d (equivalent to a fatal TLS missing_extension alert, see Section {{tls-errors}}).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will result in "Section Section X.Y" in the final output.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, that comma should be a semicolon; see #2626.

of 0x16d).

While the transport parameters are technically available prior to the completion
of the handshake, they cannot be fully trusted until the handshake completes,
Expand Down