Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't arm the handshake timer if there's no data #2590

Merged
merged 19 commits into from Apr 13, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions draft-ietf-quic-recovery.md
Expand Up @@ -1121,7 +1121,7 @@ SetLossDetectionTimer():
loss_detection_timer.update(loss_time)
return

if (crypto packets are in flight
if (has unacknowledged crypto data
|| endpoint is client without 1-RTT keys):
// Crypto retransmission timer.
if (smoothed_rtt == 0):
Expand Down Expand Up @@ -1159,7 +1159,7 @@ OnLossDetectionTimeout():
DetectLostPackets(pn_space)
// Retransmit crypto data if no packets were lost
// and there is crypto data to retransmit.
else if (has unacked crypto data):
else if (has unacknowledged crypto data):
// Crypto retransmission timeout.
RetransmitUnackedCryptoData()
crypto_count++
ianswett marked this conversation as resolved.
Show resolved Hide resolved
Expand Down